Fix memory leak when reloading unit params db #3288
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Fixes a memory leak in unit params db when it was reloaded (e.g. through
@reloadstatusdb
). This was caused because the current implementation was not freeing the existing data before creating a new one.I have also renamed
status->unit_params_destroy
tostatus->unit_params_destroy_entry
to make its objective explicit, since I now addedstatus->unit_params_clear_db
too.Thanks skyleo and Haru for the infos and suggestion on how to fix.
Issues addressed:
None